Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDBC 라이브러리 구현하기 - 1단계] 말랑(신동훈) 미션 제출합니다. #344

Merged
merged 11 commits into from
Oct 1, 2023

Conversation

shin-mallang
Copy link

안녕하세요 디노~ 추석 잘 보내고 계신가요~?
미션 잘 부탁드립니다!(명절 다 보내시구 천천히 해주셔도 돼요 :))

Copy link
Member

@jjongwa jjongwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 말랑~ 디노입니다ㅎㅎ

step 2 리팩터링 단계에서 건들게 없을 정도로 구현을 잘 해주신 것 같아요.
바로 approve & merge 하겠습니다ㅎㅎ
남은 추석 연휴 즐겁게 보내세요~~!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 테스트는 AOP와 Spring AOP 강의 이후에 진행하는 것 같습니다.!

image

}

private PreparedStatement preparedStatementWithParams(String sql, Object... params) throws SQLException {
PreparedStatement pstmt = dataSource.getConnection().prepareStatement(sql);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 리소스 회수를 해 주어야 할 것 같습니다.!

image

@jjongwa jjongwa merged commit 03722bb into woowacourse:shin-mallang Oct 1, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants