[JDBC 라이브러리 구현하기 - 1단계] 호이(이건호) 미션 제출합니다. #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpeel5839
approved these changes
Oct 2, 2023
| @@ -0,0 +1,4 @@ | |||
| # 구현 기능 목록 | |||
|
|
|||
| - [ ] UserDao에 있는 코드 JdbcTemplate으로 이동 | |||
There was a problem hiding this comment.
대단합니다!
구현 기능 목록 정리하는 거... 저도 해야하는데... 자꾸 안하게 되네요
자극 받습니다.
There was a problem hiding this comment.
ㄴㅇㄱ 저도 해야하는데... 하다가 이번에 했네요.. !!
| @FunctionalInterface | ||
| public interface RowMapper<T> { | ||
|
|
||
| T mapRow(ResultSet resultSet) throws SQLException; |
| pstmt.executeUpdate(); | ||
| } catch (SQLException e) { | ||
| log.error(e.getMessage(), e); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
조금 더 구체적인 Exception 을 사용할 수 있지 않을까요 ??
Comment on lines
+36
to
+41
| final PreparedStatement preparedStatement = conn.prepareStatement(sql); | ||
| int index = 1; | ||
| for (Object parameter : parameters) { | ||
| preparedStatement.setObject(index++, parameter); | ||
| } | ||
| return preparedStatement; |
There was a problem hiding this comment.
아예 세팅된 PreparedStatement 를 반환받도록 메서드 분리하는 것이 굉장히 좋네요!
Comment on lines
+48
to
+53
| log.debug("query : {}", sql); | ||
|
|
||
| if (rs.next()) { | ||
| return rowMapper.mapRow(rs); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
조회 결과가 2개 이상인 경우를 예외 상황이라고 본다면, 어떻게 처리 해줄 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nice to meet u 매튜
1단계를 하다 보니 코드를 수정한 커밋이 하나밖에 없네요..!
이번 JDBC 미션 잘 부탁드립니다!