[JDBC 라이브러리 구현하기 - 1,2단계] 비버(전인표) 미션 제출합니다. #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyY00n
approved these changes
Oct 2, 2023
| @@ -16,7 +16,8 @@ public UserService(final UserDao userDao, final UserHistoryDao userHistoryDao) { | |||
| } | |||
|
|
|||
| public User findById(final long id) { | |||
| return userDao.findById(id); | |||
| return userDao.findById(id) | |||
| .orElseThrow(() -> new IllegalArgumentException("일치하는 사용자가 없습니다.")); | |||
There was a problem hiding this comment.
존재하지 않는 경우의 테스트를 작성해보시면 좋을 것 같습니다~
| final PreparedStatement preparedStatement = getPreparedStatement(sql, connection, parameters); | ||
| final ResultSet resultSet = preparedStatement.executeQuery()) { | ||
| log.debug("query : {}", sql); | ||
| if (resultSet.next()) { |
There was a problem hiding this comment.
메서드 명으로 보아, 하나의 객체만 쿼리의 결과로 기대하는 것 같습니다.
그런데 쿼리 결과가 여러 행이 나올 경우를 예외로 처리하지 않은 이유가 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 로지!
이번에 추석연휴때 잘보내시고있나요?
2단계가 이렇게하는건지 잘 모르겠네요..
리뷰 잘부탁드립니다!!