[JDBC 라이브러리 구현하기 - 1단계] 매튜(김재연) 미션 제출합니다. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aak2075
approved these changes
Oct 2, 2023
| } catch (SQLException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| }; |
There was a problem hiding this comment.
아예 RowMapper라는 커스텀 함수형 인터페이스를 정의하는 것은 어떨까요?
재사용하기 더 편할 것 같습니다
Comment on lines
+69
to
+72
| List<User> user = jdbcTemplate.query(sql, rowMapper, id); | ||
| validateSingleInquiry(user); | ||
|
|
||
| try { | ||
| if (pstmt != null) { | ||
| pstmt.close(); | ||
| } | ||
| } catch (SQLException ignored) {} | ||
| return user.get(0); |
There was a problem hiding this comment.
Dao에서 매번 리스트를 반환받아서 검증하고, 0번 인덱스를 반환하기 보다
jdbctemplate에서 findById를 만들고 이쪽으로 옮기는 것이 재사용하기 좋지 않을까요?
Comment on lines
+77
to
+80
| List<User> user = jdbcTemplate.query(sql, rowMapper, account); | ||
| validateSingleInquiry(user); | ||
|
|
||
| return user.get(0); |
| @@ -14,4 +21,54 @@ public class JdbcTemplate { | |||
| public JdbcTemplate(final DataSource dataSource) { | |||
| this.dataSource = dataSource; | |||
| } | |||
|
|
|||
| public void update(String sql, Object... parameters) { | |||
| try (Connection connection = dataSource.getConnection(); | |||
| } | ||
| } | ||
|
|
||
| public <T> List<T> query( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 오랜만입니다. 기무사 출신! 마! 규성씨..
마! 규성씨에게 코드를 보여줘야 한다니 제 생에 이렇게나 떨리는 순간이 있었나 싶군요..
마! 규성씨의 그 때 그 시절처럼 제 코드를 샅샅이 뒤져봐주시고 따끔한 피드백 주세요!
마! 규성씨.. 따끔한 피드백에 미리 감사드립니다.