[JDBC 라이브러리 구현하기 - 3,4단계] 스플릿(박상현) 미션 제출합니다. #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngh0
requested changes
Oct 9, 2023
| final Connection connection = DataSourceUtils.getConnection(DataSourceConfig.getInstance()); | ||
| try { | ||
| connection.setAutoCommit(false); | ||
| appService.insert(user); |
There was a problem hiding this comment.
appService 호출 부분을 제외하고 중복이라 이 부분 제거하면 매우 깔끔해지겠네요!
TransactionSynchronizationManager 에서 startTransaction() 메서드를 만든다거나, 혹은 템플릿 콜백 or 메서드 패턴을 활용해봐도 좋을 것 같아요
| return null; | ||
| } | ||
|
|
||
| public static void bindResource(DataSource key, Connection value) { | ||
| if (Objects.isNull(resources.get())) { |
| this.appService = appService; | ||
| } | ||
|
|
||
| protected void rollback(final Connection connection) { |
There was a problem hiding this comment.
try 문안에 try 문이 있는게 개인적으로 보기 불편하더라구요..ㅎㅎ
이 메서드도 TransactionTemplate 객체로 옮겨주었습니다!!😊
| import java.sql.SQLException; | ||
| import org.springframework.jdbc.core.error.SqlExceptionConverter; | ||
|
|
||
| public abstract class TransactionService<T> { |
There was a problem hiding this comment.
이 친구가 transaction 시작과 끝 관련 책임을 가지는 것도 좋아보이네요!! 어떻게 생각하시나요?
youngh0
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 레오!!😊
구현이 조금 오래걸려서 3,4 단계 같이해서 리뷰요청 드립니다!!👍
정말 요구사항보다 더 좋은 방향으로 설계해보고자 많은 노력을 했으나 실패해버렸습니다ㅠㅠ
우선 이번단계에 대한 리뷰 시간이 많지 않으실 것 같아서 PR 보내고 이전 리뷰에 대한 코멘트 답변에 대한 부분 완성하고 DM 혹은 오프라인으로 찾아가서 말씀드리겠습니다!! 😄
그리고 최근에 컨디션 조절 못했더니 몸상태가 잘 안올라오더라구요ㅠㅠ 오늘 밤새신다고 하셨는데 너무 무리하지 마시구 화이팅입니다!! 💪