[JDBC 라이브러리 구현하기 - 4단계] 주디(오은비) 미션 제출합니다. #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh111-coder
requested changes
Oct 10, 2023
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class AppUserServiceTest { |
Comment on lines
-16
to
-17
| public void log(final Connection connection, final UserHistory userHistory) { | ||
| System.out.println("로그뜰까요아닐까용오오오"); |
Comment on lines
23
to
25
| public void insert(final User user) { | ||
| userService.insert(user); | ||
| } |
There was a problem hiding this comment.
현재 changePassword에서만 트랜잭션이 적용되고 있는데,
findById와 insert에서도 트랜잭션이 적용되어야 할 것 같아요!
적용하다 보면 트랜잭션 처리 코드가 중복될텐데,
이를 분리해보는 방법도 생각해보면 좋을 것 같아요!
(이 부분이 어렵다면 그냥 중복 트랜잭션 코드만 작성해주셔도 괜찮을 것 같아요!)
There was a problem hiding this comment.
findById는 조회인데도 트랜잭션을 적용해야하는 이유가 있나요?!
There was a problem hiding this comment.
조회 중에도 격리 수준에 따라서 데이터 정합성이 지켜지지 않는 경우가 있어서 트랜잭션을 적용하는 것이 좋을 것 같아요!
| throw new SizeException("too many result. expected 1 but was " + results.size()); | ||
| throw new DataAccessException("too many result. expected 1 but was " + results.size()); |
There was a problem hiding this comment.
여기서 기존 SizeException이 아닌 DataAccessException을 발생시키는 이유가 있나요?
sh111-coder
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
성하~ (성하 하이라는 뜻)
시간 버그가 걸렸나요?; 병원 갔다오고 약 먹구 잠깐 눈 붙였는데 하루가 지나가버렸어요...
일어나서 전 제가 1시간만 잔 줄 알았는데.....날짜가 바뀌어있더라구요? ㅎ.. 죄송합니다...
리뷰 잘 부탁드려오..