에디터 적용(이미지 삽입 기능) #1050
Merged
에디터 적용(이미지 삽입 기능) #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanull
force-pushed
the
feature/62-insert-image
branch
from
8ae53b4
to
dca26c1
Compare
feat: 학습로그 목록 조회 시 댓글 갯수도 함께 조회
hanull
force-pushed
the
feature/62-insert-image
branch
from
9901da4
to
136299c
Compare
|
aws 권한 확인중 |
|
추후 로드맵 키워드에 이미지 로드가 필요한데, s3 구현 완료되면 작업 사항 공유받고 싶어요!! |
* chore: comment svg 수정 * chore: comment svg 수정
* chore: storybook 사용을 위해 reactDocgen 에러 설정 * feat: 상위에서 크기를 제어하는 ResponsiveButton 컴포넌트 구현 * feat: LabelledImage 컴포넌트 구현 * feat: KeywordSection 컴포넌트 구현 * refactor: Omit -> Pick으로 타입 변경 * feat: fontSize를 Style Props 인자로 내려주기
* feat: 임시저장 로직 response에 ability 필드 추가 * feat: 플라이웨이에 crate studylog_temp_ability 추가 * test: 문서화 테스트 추가 * refactor: 역량 관련해서 적절한 에러로 수정 * fix: 임시저장 관련 테스트 추가 및 에러 해결 * fix: StudylogTempAbility OnDelete 속성 추가
* refactor: LoginDocument mock이용한 테스트로 수정 * refactor(MissionDocumentation): mock이용한 테스트로 수정 * refactor(ProfileDocumentation): mock이용한 테스트로 수정 + response fixture 생성 * refactor(CommentDocumentation): mock 이용한 테스트로 수정 * refactor(MemberDocumentation, MemberReactionDocumentation): mock 이용한 테스트로 수정 * refactor(SessionMemberDocumentation): mock 이용한 테스트로 수정 * refactor(TagDocumentation): mock 이용한 테스트로 수정 * refactor(StudylogOverviewDocumentation): mock 이용한 테스트로 수정 * refactor(StudylogRssFeedDocumentation): mock 이용한 테스트로 수정 * chore: 자바 버전을 8에서 9로 변경 * test(StudylogRssFeedDocumentation): 응답 fixture로 빼기
This reverts commit 34f6033.
This reverts commit 7a10a3e.
This reverts commit 7ef107b.
This reverts commit b1a0d76.
This reverts commit 66e4d08.
|
SonarCloud Quality Gate failed. |
seokhongkim
reviewed
Oct 18, 2022
| private PutObjectRequest getPutObjectRequest(final MultipartFile uploadImageFile) { | ||
| return PutObjectRequest.builder() | ||
| .bucket(bucket) | ||
| .key(uploadImageFile.getOriginalFilename()) |
There was a problem hiding this comment.
같은 이름 파일 업로드되면 파일이 변경될 것 같은데 혹시 방어 로직이 있나요?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 사항
Close #62