-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apply): link the my application page with the example judgment api #660
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a8f5b24
refactor: 도메인 용어 통일 test-result -> judgment result
KangYunHo1221 6a50deb
refactor: API 수정사항 반영
KangYunHo1221 4d234ae
fix: arrow function typos
KangYunHo1221 bb3b2bf
refactor: judgment result text
KangYunHo1221 1b3dde1
feat: 미션 타임아웃 로직 추가
KangYunHo1221 08faffd
feat: 예제 테스트 실행 에러 핸들링(refetch 로직 추가)
KangYunHo1221 aadd98c
fix: API 변경점 적용
KangYunHo1221 57908d9
fix: timeout에 대한 버튼 상태 수정
KangYunHo1221 ee58aa7
feat: 새로고침에 대한 알림추가
KangYunHo1221 63f6bc4
refactor: ts->tsx로 파일 변경, testStatus -> judgmentStatus로 변경
KangYunHo1221 ce3526b
fix: typos (Fail -> Failed)
KangYunHo1221 18ec15c
refactor: 용어 변경 (pending -> started)
KangYunHo1221 5e12de3
refacor: dummy.ts 에서 const를 사용하도록 변경
KangYunHo1221 57a3003
refactor: isJudgmentTimedOut 인자 변경(isoTime -> Mission['judgment']
KangYunHo1221 6fe20a1
refactor: 실제로 새로고침 한 후 새로고침을 보여주도록 변경
KangYunHo1221 6c995a1
refactor: judgmentResultText type 분리
KangYunHo1221 deb64f0
refactor: judgebutton 실행 실패시 에러처리 변경
KangYunHo1221 a9c5bb3
refactor: timeout 변수 분리
KangYunHo1221 7f65aa9
feat: 예제테스트 실행에 대한 PR주소를 보여주지 않도록 수정
KangYunHo1221 a776f87
fix: judgment button 조건문 적용 및 dummy 추가
KangYunHo1221 1f5bcfc
refactor: 변경된 judgment 응답형식 적용(isAutomation -> runnable)
KangYunHo1221 b10c62c
fix: 툴팁 스타일 변경(툴팁이 버튼을 가리는 오류 수정)
KangYunHo1221 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
frontend/src/components/MyApplicationItem/JudgmentResult/JudgmentResult.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
.judgment-result-text { | ||
margin-bottom: 0.2rem; | ||
font-size: 1.125rem; | ||
font-weight: bold; | ||
} | ||
|
||
.judgment-result-score.default { | ||
color: var(--black); | ||
} | ||
|
||
.judgment-result-score.started { | ||
color: var(--blue); | ||
} | ||
|
||
.judgment-result-score.pass { | ||
color: var(--green); | ||
} | ||
|
||
.judgment-result-score.fail { | ||
color: var(--red); | ||
} | ||
|
||
.judgment-result-score.error { | ||
color: var(--red); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
frontend/src/components/MyApplicationItem/JudgmentResult/JudgmentResult.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import classNames from "classnames"; | ||
import { Mission } from "../../../../types/domains/recruitments"; | ||
import formatJudgmentResult from "./../../../utils/format/judgmentResult"; | ||
import styles from "./JudgmentResult.module.css"; | ||
|
||
export type JudgmentResultProps = { | ||
judgment: Mission["judgment"]; | ||
}; | ||
|
||
const JudgmentResultText = ({ judgment }: JudgmentResultProps) => { | ||
const { text, type } = formatJudgmentResult(judgment); | ||
|
||
return ( | ||
<div className={styles["judgment-result-text"]}> | ||
<span>예제 테스트 결과 : </span> | ||
<span className={classNames(styles["judgment-result-score"], styles[type])}>{text}</span> | ||
</div> | ||
); | ||
}; | ||
|
||
export default JudgmentResultText; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ const MyApplicationFormItem = ({ recruitment, submitted }: MyApplicationFormItem | |
const isButtonDisabled = isApplicationDisabled(submitted, recruitment.recruitable); | ||
const buttonLabel = applicationLabel(submitted, recruitment.recruitable); | ||
|
||
const routeToApplicationForm = (recruitment: Recruitment) => () => { | ||
const routeToApplicationForm = (recruitment: Recruitment) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a: 👏👏👏 |
||
navigate( | ||
{ | ||
pathname: generatePath(PATH.APPLICATION_FORM, { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 0 additions & 21 deletions
21
frontend/src/components/MyApplicationItem/PullRequestUrl/PullRequestUrl.tsx
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
frontend/src/components/MyApplicationItem/TestResult/TestResult.module.css
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c:
isJudgmentTimedOut
에서 아예missionItem.judgment
를 받을 수 있게 하고, 함수 내에서 한번 방어처리하면 어떨까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils 성격상 time을 받아서 쓰려고 했는데,
이미 함수명에 judgment로 한정 돼 있고 방어처리도 내부에서 하는게 더 깔끔해 보이네요!
수정하였습니다.