Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show stock photos only for wpcom or jetpack sites #10745

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Nov 6, 2019

Fixes # wordpress-mobile/gutenberg-mobile#1539 (comment)

We should not show the Free Media Library option on Self Hosted site, since this is a WPCom/Jetpack-only feature.

To test:

Test 1:

  1. The easiest way is to create a Jurassic Ninja instance:
    https://jurassic.ninja
  2. Then delete the Jetpack plugin from it
  3. Log in with a self-hosted site
  4. Create a new Post
  5. Create a new Image block
  6. Tap on the Image block
  7. Choose from Free Photo Library shouldn't be visible

Test 2:

  1. Use wp.com site
  2. Create a new Post
  3. Create a new Image block
  4. Tap on the Image block
  5. Choose from Free Photo Library should be visible

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marecar3 marecar3 merged commit c9e3eb1 into release/13.6 Nov 7, 2019
@marecar3 marecar3 deleted the gutenberg/hotfix/allow_stock_photos_only_on_wpcom_or_jetpack branch November 7, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants