Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetpack Plugin Install] Reuse the tweaked UI for remote Jetpack install #18058

Merged
merged 13 commits into from
Mar 16, 2023

Conversation

thomashorta
Copy link
Contributor

@thomashorta thomashorta commented Mar 6, 2023

Fixes #18045

Update the existing "Remote Install" Flow to use this same updated flow (made with Compose). This flow is triggered when the user clicks a Jetpack feature (such as Stats) without having the Jetpack plugin installed on their self-hosted site.

Demo

Success Flow
issue-18045-jp-install-remote-success-blur.mov
Error Flow
issue-18045-jp-install-remote-error.mp4

To test

Set up a self-hosted site that has only no Jetpack plugins at all.

  1. Install Jetpack OR WordPress app
  2. Login using the site credentials
  3. Select the self-hosted site from the site list
  4. Tap a Jetpack feature, such as Stats
  5. Testing the error state
    1. Turn on Airplane mode
    2. Start the Plugin Install Flow
    3. Verify the UI is updated according to expectations
  6. Testing the install flow
    1. Close the Plugin Install flow
    2. Turn off Airplane mode
    3. Tap a Jetpack feature, such as Stats
    4. Start the Plugin Install Flow
    5. Verify the UI is updated according to expectations
    6. Verify everything worked and the Jetpack plugin was installed

Regression Notes

  1. Potential unintended areas of impact
    Changes in installation behavior.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual test (it is working exactly as it was before).

  3. What automated tests I added (or what prevented me from doing so)
    Updated existing tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 6, 2023

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18058-d8c78c8.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitd8c78c8
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 6, 2023

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18058-d8c78c8.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitd8c78c8
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@thomashorta thomashorta force-pushed the issue/18045-jp-install-reuse-ui branch from 267d304 to 6595050 Compare March 6, 2023 17:05
Base automatically changed from issue/18005-jp-full-plugin-ui-tweaks to trunk March 9, 2023 14:03
@thomashorta thomashorta force-pushed the issue/18045-jp-install-reuse-ui branch from d8c78c8 to 96de52a Compare March 13, 2023 18:59
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 13, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18058-820cc08
Commit820cc08
Direct Downloadwordpress-prototype-build-pr18058-820cc08.apk
Note: Google Login is not supported on these builds.

@thomashorta thomashorta marked this pull request as ready for review March 13, 2023 19:18
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 13, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 13, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18058-820cc08
Commit820cc08
Direct Downloadjetpack-prototype-build-pr18058-820cc08.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @thomashorta

It works as expected. I've left a question, but LGTM :shipit:

}

override fun onBackPressed() {
if (viewModel.liveViewState.value?.showCloseButton == false) return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Would it make sense to move this if and the trackWithSource call to the ViewModel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will not make a lot of difference in the code here as I still need to return some information saying the back should be blocked, but it's better in terms of testing the analytics. I will do the change.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@thomashorta thomashorta merged commit 6cb5e5b into trunk Mar 16, 2023
@thomashorta thomashorta deleted the issue/18045-jp-install-reuse-ui branch March 16, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jetpack Plugin Install] Reuse the new UI for jetpack remote install flow
3 participants