Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg/free media library #12858

Merged
merged 12 commits into from
Nov 7, 2019
Merged

Gutenberg/free media library #12858

merged 12 commits into from
Nov 7, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Nov 5, 2019

Fixes wordpress-mobile/gutenberg-mobile#720

This PR implements the iOS Bridge code needed for Stock Photos (Pexels) and wordpress-mobile/gutenberg-mobile#1265

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1539

pexels

Note:

  • The "Free Photo Library" is the same as used on Aztec.

  • I decided to make the Free Photos Library multi-selectable, even though we haven't activated this feature on iOS yet. I can keep it single selectable if we decide that this is better.

  • There are some few small changes on the bridge media picker/upload methods, so it would be good to test all options on all media related blocks.

  • I noticed that we could improve some things in the JS side, but opted to keep this PR focused on adopting the current implementation to avoid the need of Android changes.

To test:

Image Block:

  • Add an Image block.
  • Check that the "Free Photo Library" option is there.
  • Open the Free Photo Library.
  • Choose one (or many) images.
  • Check that all images selected are added.
  • Check that you can select only images in all other options.

Video Block:

  • Add a video block.
  • Check that "Free Photo Library" is NOT in the options.
  • Check that you can only select videos in all other options.

Media&Text:

  • Add an Media&Text block.
  • Check that the "Free Photo Library" option is there.
  • Open the Free Photo Library.
  • Choose one (or many) images. (Multi-select is also possible on Android)
  • Check that all images selected are added. (Extra images will be added as Image Block)
  • Check that you can select images and videos in all other options.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Nov 5, 2019
@etoledom etoledom added this to the 13.7 milestone Nov 5, 2019
@etoledom etoledom self-assigned this Nov 5, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 5, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just need to update the release notes!

@etoledom etoledom added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 7, 2019
@etoledom etoledom merged commit 29958a9 into develop Nov 7, 2019
@etoledom
Copy link
Contributor Author

etoledom commented Nov 7, 2019

Thank you!

@etoledom etoledom deleted the gutenberg/free-media-library branch November 13, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pexels and Giphy search not available form image block
3 participants