Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg - Add list block v2 flag #19116

Merged
merged 14 commits into from
Aug 3, 2022
Merged

Gutenberg - Add list block v2 flag #19116

merged 14 commits into from
Aug 3, 2022

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Jul 27, 2022

Related PRs:

Adds a Gutenberg feature flag for the List V2 block.

Fixes:

To test:
Check the Gutenberg PR description for further testing instructions.

Regression Notes

  1. Potential unintended areas of impact
    Block editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual block editor testing

  3. What automated tests I added (or what prevented me from doing so)
    None. This feature flag is temporary until List v2 is fully implemented by web and mobile.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 27, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19116-dc8c95c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Podfile Outdated
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :tag => ''
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => ''
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :commit => ''
pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :commit => 'fbb2625865d1e4a02f1f1f9b1cee57448b76055c'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Use the new Ruby 1.9 hash syntax.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 27, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19116-dc8c95c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@derekblank derekblank added the Gutenberg Editing and display of Gutenberg blocks. label Jul 28, 2022
@geriux geriux marked this pull request as ready for review July 29, 2022 11:15
@geriux geriux added this to the 20.5 milestone Jul 29, 2022
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@geriux geriux merged commit 8593a63 into trunk Aug 3, 2022
@geriux geriux deleted the gutenberg/add-list-v2-flag branch August 3, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants