Fix focus PostTitle on new posts regression. #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2019
Merged
|
Hi @etoledom 👋 Was the WPiOS PR mentioned here:
meant to link to the DarkMode PR, or a different one? |
Yes, it's the DarkMode PR. The CI was failing on that PR due to this focus issue, so I'm using this commit on that PR to test this solution on WPiOS CI. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression where the event "setTitleFocus" was not handled properly on the JS side. This had the effect that the Title was not set to focus on new (empty) posts.
gutenbergside PR: WordPress/gutenberg#17180WPiOS PR: wordpress-mobile/WordPress-iOS#12379To test:
The UI Tests on the WPiOS branch should also be passing now.
cc @JavonDavis
Update release notes:
RELEASE-NOTES.txt.