Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show new block indicator in default appender too #1542

Merged
merged 11 commits into from
Nov 6, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Nov 5, 2019

Fixes #632

Addresses the subcase in #632 where the new-block indicator wasn't shown when the block list was empty and not interacted with yet.

Also, showing the indicator when at the last block of the list.

Gutenberg PR: WordPress/gutenberg#18289

To test:

  1. Locally edit the initial-html.js file to have an empty block list
  2. Run the demo app
  3. Tap on the "+" button to insert a new block
  4. Notice the "ADD BLOCK HERE" indicator right below the title block 🎉

To test 2:

  1. Locally edit the initial-html.js file to have an empty block list
  2. Run the demo app
  3. Type some text in the "Start writing" prompt
  4. Tap on the "+" button to insert a new block
  5. Notice the "ADD BLOCK HERE" indicator right below the paragraph block 🎉

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added this to the 1.17 milestone Nov 5, 2019
@hypest hypest requested a review from mchowning November 5, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add New Block" indicator isn't shown when title field is focused
2 participants