Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug configuration for VSCode #1550

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Update debug configuration for VSCode #1550

merged 1 commit into from
Nov 6, 2019

Conversation

koke
Copy link
Member

@koke koke commented Nov 6, 2019

It seems the old config was broken with newer versions of the extension. I removed the config and inserted the default entries.

I've also removed the options to launch iOS and Android since they are not working right now

To test:

  • Open VSCode
  • Run yarn start
  • Launch the demo app on the simulator
  • From VSCode, choose Debug > Start Debugging
  • From the simulator, launch the dev menu and choose Debug JS Remotely

The bottom bar on VSCode should turn red, and you should be able to set breakpoints and use the debugger

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@koke koke added the Tooling label Nov 6, 2019
@koke koke added this to the 1.17 milestone Nov 6, 2019
@maxme maxme self-requested a review November 6, 2019 15:02
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, this is much better than using the Chrome dev tools!

Screenshot 2019-11-06 at 16 13 24

:shipit:

@koke koke merged commit b88b97a into develop Nov 6, 2019
@koke koke deleted the fix/vscode-debug branch November 6, 2019 15:16
@hypest hypest mentioned this pull request Nov 11, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants