Prevent "Undo Level" after Setting Featured Image via Image Block #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
3 tasks
added 9 commits
July 30, 2021 17:46
fluiddot
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Approved via WordPress/gutenberg#33057 (review).
NOTE: The Gutenberg reference should point to the merge commit in Gutenberg before merging this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended as a temporary workaround for WordPress/gutenberg#32937
gutenberg: WordPress/gutenberg#33057Description
The undo/redo functionality doesn't work as expected after setting a featured image via the image block.
After setting a featured image via the block and then tapping undo, it appears as though the action has successfully reverted, as the Featured banner is removed from the block. However, the image still remains as the post's featured image.
With this PR, the issue is worked around by preventing an "undo level" from being created after a featured image is set via the image block. Tapping undo or redo immediately after setting a featured image via the image block should no longer have any effect, therefore avoiding the previous buggy behaviour.
See the Gutenberg PR for further details.
Testing
To test: Please refer to the Gutenberg PR as the most central, up-to-date place for testing instructions.
PR submission checklist: