Uses the global store for the post title and adds undo/redo support. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
added
the
[Type] Enhancement
|
Fyi, @daniloercoli |
This was referenced Jan 25, 2019
diegoreymendez
requested review from
daniloercoli
and removed request for
Tug and
pinarol
|
Reassigned to @daniloercoli since he's working on the title feature with me. |
daniloercoli
approved these changes
Jan 28, 2019
pinarol
reviewed
Jan 28, 2019
| @@ -92,7 +91,7 @@ class AppContainer extends React.Component<PropsType, StateType> { | |||
| toggleHtmlModeAction={ this.toggleHtmlModeAction } | |||
| setTitleAction={ this.setTitleAction } | |||
There was a problem hiding this comment.
Hey @diegoreymendez 👋 it looks to me that we can also get rid of passing this.setTitleAction as a prop from component to component. So other components can also use editPost( { title: title } ) via their own props with the help of withDispatch. what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Following @Tug 's indications here, this PR wires our title to the global store title.
This PR also adds undo/redo support for the title.
Moves forward #372 .
Dependencies:
Gutenberg PR: WordPress/gutenberg#13514
Testing:
Testing edits:
Make sure the title is still as you left it before switching modes.
Testing undo redo:
Make sure undo / redo works as it does in web-Gutenberg (ie: that's our baseline for comparing).