Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing InspectorControls.Slot for inline toolbar buttons. #527

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Implementing InspectorControls.Slot for inline toolbar buttons. #527

merged 3 commits into from
Jan 31, 2019

Conversation

etoledom
Copy link
Contributor

This PR implements the changes made on WordPress/gutenberg#13597 to display inline toolbar buttons declared by each block.

On this particular PR, the Images settings button will be displayed, towards the task described here:
#202

simulator screen shot - iphone x - 2019-01-30 at 14 47 46

To test:

  • Run the project.
  • Select an Image block with an image.
  • Check that the settings button is displayed like in the screenshot.
  • Select an empty image block.
  • Check that the settings button is not there.

@etoledom etoledom added the [Type] Enhancement Improves a current area of the editor label Jan 30, 2019
@etoledom etoledom added this to the Beta milestone Jan 30, 2019
@etoledom etoledom self-assigned this Jan 30, 2019
@etoledom etoledom requested a review from Tug January 30, 2019 14:40
@etoledom etoledom mentioned this pull request Jan 30, 2019
Merged
Tug
Tug approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@etoledom etoledom merged commit e57deec into develop Jan 31, 2019
@etoledom etoledom deleted the issue/add-image-settings-button branch January 31, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

Assignees

@etoledom etoledom

Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @Tug