[Mobile] Update toolbar icons and colors #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
added 8 commits
July 12, 2023 18:22
geriux
force-pushed
the
version-toolkit/gutenberg/rnmobile/update-mobile-toolbar-icons-and-color
branch
from
3b868ed
to
bbd3482
Compare
|
Hey @fluiddot 👋 I was wondering if you could also review this PR! Let me know, thanks! |
Sure thing, I'm taking a look right now. |
fluiddot
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Approved via WordPress/gutenberg#52336 (review).
I checked the screenshot updates and confirmed that the toolbar is displayed with the new styles. I noticed that a couple of them were updated but couldn't find a real difference, I assume this is a minor issue as the new version looks as expected.
added 2 commits
July 17, 2023 12:45
…obile-toolbar-icons-and-color
geriux
deleted the
version-toolkit/gutenberg/rnmobile/update-mobile-toolbar-icons-and-color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
This PR updates the current colors for the toolbar icons, the toolbar itself, and the safe area background.
For a better PR description and testing steps please check the Gutenberg PR linked above.