-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus on title when creating a new post. #599
Conversation
I've left just a couple of comments, but this PR is LGTM once those and GB conflicts are resolved! Did you test this PR by integrating it into the main wp-ios or wp-android apps? As discussed in Slack convo, we may want to iterate on this, and read the |
No, but I purposely left that out of the scope of this PR. As soon as we close this I'll submit a PR to test the integration and make any necessary changes (which I expect will be none). In my modest opinion, it's in our best interest to try and work with more and more incrementally, unless there's a good reason to hold everything back. This ensures we don't spend a lot of time synching both open PRs due to very small pending changes / fixes. We've seen some of this in the past and I'd like to avoid spending time to maintain a lot of open PRs unless it's really necessary to avoid breakage (in this case, the result won't be worse than it was before). |
Comments adressed @daniloercoli . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once gutenberg
ref is updated.
Description:
Resolves wordpress-mobile/WordPress-iOS#10594
This PR focuses the title when opening Gutenberg, if the post has no title and no content. This is a simplified and initial approach, that seems to be enough to match the condition that we're dealing with a new post.
If we find this condition isn't enough we can expand incrementally.
Related PRs:
Gutenberg: WordPress/gutenberg#13874
Testing:
Test 1:
Make sure the focus is NOT in the title, since it's not empty and there are blocks.
Test 2:
App.js
, and forceinitialTitle = '';
andinitialData = '';
.Make sur the focus is in the title, since the title is empty and there are no blocks.