Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fix for RichTextInputEvent #612

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Use fix for RichTextInputEvent #612

merged 1 commit into from
Feb 18, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 18, 2019

Gutenberg side fix to effectively bypass the RichTextInputEvent component.

To test:

  • Run the demo app
  • Tap inside a paragraph block
  • Tap some characters. The should work as normal without crashing.

@hypest hypest mentioned this pull request Feb 18, 2019
Merged
5 tasks
SergioEstevao
SergioEstevao approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@marecar3 marecar3 self-requested a review February 18, 2019 19:39
@marecar3
Copy link
Contributor

LGTM on Android device!

@marecar3 marecar3 merged commit fa2433f into develop Feb 18, 2019
@marecar3 marecar3 deleted the fix/ground-rich-text-input-event branch February 18, 2019 20:32
@marecar3 marecar3 restored the fix/ground-rich-text-input-event branch February 18, 2019 20:33
@marecar3 marecar3 deleted the fix/ground-rich-text-input-event branch February 18, 2019 20:34
@hypest
Copy link
Contributor Author

hypest commented Feb 18, 2019

Thanks for reviewing @SergioEstevao and @marecar3 !

@hypest
Copy link
Contributor Author

hypest commented Feb 18, 2019

Just to be sure sure, I've restarted the failing Travis job (https://travis-ci.org/wordpress-mobile/gutenberg-mobile/builds/495099445) and this time it succeeded 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hypest @marecar3 @SergioEstevao