Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a red sceen when pasting. #638

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 21, 2019

Description:

Fixes a red screen that would come up when trying to paste plain text at the end of a block or when text was selected.

Dependencies:

Gutenberg PR: WordPress/gutenberg#14011

Known issues:

The text selection after pasting is not correct, but this is not a problem introduced by this PR.

Testing:

Test 1:

  1. Copy some plain text.
  2. Select some text from a block.
  3. Paste

Make sure you don't get a red screen.

Test 2:

  1. Copy some plain text.
  2. Place the caret at the end of a paragraph or heading block.
  3. Paste

Make sure you don't get a red screen.

@diegoreymendez diegoreymendez added the [Type] Bug Something isn't working label Feb 21, 2019
@diegoreymendez diegoreymendez added this to the Beta milestone Feb 21, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 21, 2019
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegoreymendez diegoreymendez changed the title Fixes an red sceen when pasting. Fixes a red sceen when pasting. Feb 21, 2019
@diegoreymendez
Copy link
Contributor Author

Thanks @etoledom !

@diegoreymendez diegoreymendez merged commit 0c6fefb into develop Feb 22, 2019
@diegoreymendez diegoreymendez deleted the issue/624-pasting-into-selected-text branch February 22, 2019 04:09
@mkevins
Copy link
Contributor

mkevins commented Feb 22, 2019

Thanks @diegoreymendez. I tried this on Android, and it fixes the issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants