Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement quote block in RN #963

Merged
merged 13 commits into from
May 24, 2019
Merged

Implement quote block in RN #963

merged 13 commits into from
May 24, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented May 7, 2019 •
edited by hypest
Loading

Refs #207

Gutenberg PR: WordPress/gutenberg#15482

How to test:

  • Open the demo app and check if quotes in content are displayed correctly
  • Interact with quote elements by adding text, new lines on the quote part and citation part.
  • Try adding new quote element
  • Write on it.

@SergioEstevao SergioEstevao added this to the v1.5 milestone May 7, 2019
@hypest
Copy link
Contributor

hypest commented May 15, 2019

Moving to next milestone.

@hypest hypest modified the milestones: v1.5, v1.6 May 15, 2019
@SergioEstevao SergioEstevao self-assigned this May 16, 2019
@SergioEstevao SergioEstevao requested a review from hypest May 21, 2019 15:33
@SergioEstevao SergioEstevao marked this pull request as ready for review May 21, 2019 15:35
@SergioEstevao SergioEstevao mentioned this pull request May 21, 2019
Merged
hypest
hypest approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see support for a new block by just updating the GB hash :)

LGTM!

@SergioEstevao SergioEstevao merged commit cdf1453 into develop May 24, 2019
@SergioEstevao
Copy link
Contributor Author

I went forward and merge this in because the failing CI Test is happening randomly without relation to the code changes. For the record, the local tests are passing.

@SergioEstevao SergioEstevao deleted the issue/implement_quote_block branch May 24, 2019 14:06
This was referenced May 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@etoledom etoledom Awaiting requested review from etoledom

@koke koke Awaiting requested review from koke

Assignees

@SergioEstevao SergioEstevao

Labels
Blocks
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @hypest