dwc_eqos - Load ACPI configuration information #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to acpiutil: - `acpiutil.hpp` depends on definitions from `acpiioct.h`, so `#include` it. - Fix code analysis warnings about SAL annotations. - Make `AcpiEvaluateMethod` be public. - Fix C++ conformance issues with goto jumping past variable initialization. Changes to driver: - Define a DeviceConfig struct with all of the configuration information. - Pass DeviceConfig to queues. - Queues use DeviceConfig instead of constants. - Initialize DeviceConfig based on feature registers and ACPI. Notes: - Current ACPI sets mixed-burst=1, tso=1, wr_osr_lmt=4, rd_osr_lmt=8, blen=16,8,4. - NetBSD driver references other settings that are not present in the current ACPI, and sets defaults for them: pbl=8, txpbl=8, rxpbl=8, fixed-burst=0. - I invented a new value `pblx8` (default = 1) to control whether the X8 flag is set. Existing code assumes that it is set. - I don't use the `tso` value for anything. I assume it is to enable/disable TCP segmentation offload, which seems more appropriate to configure in the registry. - The docs say that mixed-burst=1 should translate into FB=0 (same as fixed-burst=0), but the NetBSD driver translates mixed-burst=1 into Reserved14=1. I'll keep that behavior since it doesn't seem to cause any harm.
mariobalanica
requested changes
Dec 30, 2023
mariobalanica
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to acpiutil:
acpiutil.hppdepends on definitions fromacpiioct.h, so#includeit.AcpiEvaluateMethodbe public.Changes to driver:
Notes:
pblx8(default = 1) to control whether the X8 flag is set. Existing code assumes that it is set.tsovalue for anything. I assume it is to enable/disable TCP segmentation offload, which seems more appropriate to configure in the registry.