Anant/additional retries #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickles-bread-and-butter
requested review from
aalavian,
anantsimran,
varshaparthay and
valentin-woven
as code owners
anantsimran
reviewed
Sep 21, 2023
wicker/core/storage.py
Outdated
| @@ -92,17 +125,24 @@ def fetch_file_s3(self, input_path: str, local_prefix: str, timeout_seconds: int | |||
| os.makedirs(os.path.dirname(local_path), exist_ok=True) | |||
|
|
|||
| while not os.path.isfile(success_marker): | |||
| with SimpleUnixFileLock(lock_path, timeout_seconds=timeout_seconds): | |||
| with SimpleUnixFileLock(lock_path, timeout_seconds=1000): | |||
There was a problem hiding this comment.
@isaak-willett I had a chat with @aalavian where he mentioned we should not be doing this. Can we change the timeout back here?
anantsimran
force-pushed
the
anant/additional_retries
branch
from
b529c7a
to
274b7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.