Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

(bug): Extensions Not Showing Up #7

Merged

Conversation

jasonbahl
Copy link
Contributor

This fixes a bug where the assets for the GraphiQL Extensions (Auth Switch / Composer) were enqueued in the wrong order and not executing properly.

…uth Switch / Composer) were enqueued in the wrong order and not executing properly.
@jasonbahl jasonbahl self-assigned this Dec 6, 2021
@justlevine
Copy link

Confirmed working
image

@jasonbahl
Copy link
Contributor Author

@justlevine sweet!

I'm still not sure why the button text is black on the "Add New Query" and "Add New Mutation" buttons.

Likely similar issue, but with the style assets? 🤔 👀

@jasonbahl
Copy link
Contributor Author

It's weird, though, the button text is white for me, before and after this bugfix. 🤔

Can you maybe inspect the CSS on those buttons and screenshot what you see in the devtools for why the text is black?

They should look like:

Screen Shot 2021-12-06 at 10 59 42 AM

@justlevine
Copy link

seems the specificty of .graphiql-container button wins out over .ant-btn-primary

image

@jasonbahl
Copy link
Contributor Author

Ah ha! I see.

And I know why it's different on my machine and yours 🤦🏻‍♂️ .

I'll work on the fix. Thanks for the screenshot. 🙌🏻

…v as it causes some style conflicts with ant design
@jasonbahl
Copy link
Contributor Author

@justlevine the black button text should be resolved now. I'll get this merged and released.

Thanks! 🙏🏻

@jasonbahl jasonbahl merged commit fde702b into wp-graphql:master Dec 6, 2021
@jasonbahl
Copy link
Contributor Author

@justlevine aside: what browser are you on?

All those scrollbars are making me cringe! 😆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants