Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localAttributes and globalAttributes filtering and returned wrong values. #757

Merged
merged 4 commits into from
Jul 4, 2023
Merged

fix: localAttributes and globalAttributes filtering and returned wrong values. #757

merged 4 commits into from
Jul 4, 2023

Conversation

creative-andrew
Copy link
Contributor

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Removes type filtering on globalAttributes and localAtrributes
  • Fixes type filtering on attributes
  • Fixes correct data is returned for globalAttributes and localAttributes

Does this close any currently open issues?

Closes: #756

Any relevant logs, error output, GraphiQL screenshots, etc?

See: #756

@creative-andrew creative-andrew changed the title fix: Localattribute and globalAttribute filtering. fix: localattributes and globalAttributes filtering and returned wrong values. Jun 29, 2023
kidunot89
kidunot89 requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. Just see my comments

includes/connection/class-product-attributes.php Outdated Show resolved Hide resolved
includes/connection/class-product-attributes.php Outdated Show resolved Hide resolved
@kidunot89 kidunot89 added the breaking change Solution will break some older solutions label Jun 29, 2023
@kidunot89 kidunot89 changed the title fix: localattributes and globalAttributes filtering and returned wrong values. fix: localAttributes and globalAttributes filtering and returned wrong values. Jul 4, 2023
kidunot89
kidunot89 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, bro👍🏿

kidunot89
kidunot89 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, bro👍🏿

@kidunot89 kidunot89 merged commit fedde04 into wp-graphql:develop Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidunot89 kidunot89 kidunot89 approved these changes

Assignees
No one assigned
Labels
breaking change Solution will break some older solutions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attributes, globalAttribute and localAttribute return wrong values
2 participants
@creative-andrew @kidunot89