Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug fixed in Product_Connection_Resolver::add_tax_query #820

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Fixes minor bug is Product_Connection_Resolver::add_tax_query

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 self-assigned this Nov 30, 2023
@kidunot89 kidunot89 force-pushed the fix/product-connection-resolver-tax-query-fix branch from 924d878 to 7ffcd59 Compare November 30, 2023 13:42
@kidunot89 kidunot89 merged commit 753a0fa into wp-graphql:develop Dec 22, 2023
14 checks passed
@kidunot89 kidunot89 deleted the fix/product-connection-resolver-tax-query-fix branch December 22, 2023 23:06
@kidunot89 kidunot89 added the bugfix Implements bugfix label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant