Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors on configuring-graphql-client-for-user-session.md #893

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

zalito12
Copy link
Contributor

Some typos and errors with Apollo Link examples

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Fix errors on documentation

Does this close any currently open issues?

No

Any relevant logs, error output, GraphiQL screenshots, etc?

No

Any other comments?

No

Some typos and errors with Apollo Link examples
Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zalito12 Thanks for taking the time to fix this.

@kidunot89 kidunot89 merged commit 2f663a4 into wp-graphql:develop Oct 2, 2024
1 check passed
@alexismo
Copy link

@zalito12 Trying your updated version of createUpdateLink, I'm getting

⨯ TypeError: forward is not a function
    at createUpdateLink (webpack-internal:///./apollo/client.js:118:12)

@zalito12
Copy link
Contributor Author

@zalito12 Trying your updated version of createUpdateLink, I'm getting

⨯ TypeError: forward is not a function
    at createUpdateLink (webpack-internal:///./apollo/client.js:118:12)

Could you provide more context? What are you passing as forward? I just removed a typo =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants