Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merl 1306 multiple queries #1661

Merged
merged 20 commits into from
Dec 14, 2023
Merged

Merl 1306 multiple queries #1661

merged 20 commits into from
Dec 14, 2023

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Nov 28, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

This PR adds a new possible field on a Faust WordPress Template called queries. This property allows you to supply multiple queries and variables to one Faust Template.

Related Issue(s):

Testing

  1. Checkout this branch
  2. Build the packages npm run build
  3. Start the example project npm run dev -w @faustwp/getting-started-example
  4. Visit a Single post template and notice that the multiple queries are being resolved as expected.
  5. Visit a Page template and notice that the singe query works as intended.
  6. Visit a mix of both single posts and pages; trying previews for each, CSR, and regular SSG to look for any irregularities.
  7. Try to break it. There are a number of changes in core Faust features here so we want to make sure there is no regression.

New unit tests for WordPressTemplate have been added.

Screenshots

Documentation Changes

Dependant PRs

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 67b561f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theodesp
Copy link
Member

Some conflicts...

Copy link
Contributor

github-actions bot commented Nov 29, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 246.05 KB (🟡 +537 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/preview 282 B 246.32 KB 70.38% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@theodesp
Copy link
Member

@blakewilson looks good. I didn't find any issues. Lets get one more approval

@mindctrl
Copy link
Contributor

@blakewilson is this supposed to be a draft or is it ready for final review?

@blakewilson
Copy link
Contributor Author

@blakewilson is this supposed to be a draft or is it ready for final review?

This is now ready for review.

@blakewilson blakewilson marked this pull request as ready for review December 12, 2023 17:20
@blakewilson blakewilson requested a review from a team as a code owner December 12, 2023 17:20
@blakewilson blakewilson merged commit c79c8c2 into canary Dec 14, 2023
18 checks passed
@blakewilson blakewilson deleted the MERL-1306-multiple-queries branch December 14, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants