Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on page transition with multiple queries #1737

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Jan 17, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Fixes #1731

Related Issue(s):

Testing

Reproduce steps in #1731 but noticed the correct expected behavior.

Screenshots

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner January 17, 2024 03:09
Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 45b30e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 246.12 KB (🟡 +22 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Contributor

@mindctrl mindctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@blakewilson blakewilson merged commit 1b495d7 into canary Jan 17, 2024
17 of 18 checks passed
@blakewilson blakewilson deleted the fix-multiple-queries-page-transitions branch January 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Multiple queries fails on page transition to "queries" template
3 participants