Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd controllers] Java CommandXboxController.leftTrigger(EventLoop, double) is wrong parameter order #5826

Closed
KangarooKoala opened this issue Oct 25, 2023 · 0 comments · Fixed by #5831
Labels
component: command-based WPILib Command Based Library good first issue Good for newcomers. type: bug Something isn't working.

Comments

@KangarooKoala
Copy link
Contributor

Describe the bug
CommandXboxController has overloads for leftTrigger() and rightTrigger() that specify the event loop the trigger will be bound to, as well as the threshold for the trigger. However, the left trigger overload is leftTrigger(EventLoop, double) while the right trigger overload is rightTrigger(double, EventLoop).

Expected behavior
I expect both methods to have the same parameter order. Looking at the other controllers, it seems that EventLoop last is the standard, and the C++ version also has the EventLoop as the last parameter. (Though interestingly, the Trigger constructor has EventLoop first.)

@calcmogul calcmogul added type: bug Something isn't working. component: command-based WPILib Command Based Library labels Oct 26, 2023
@rzblue rzblue added the good first issue Good for newcomers. label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: command-based WPILib Command Based Library good first issue Good for newcomers. type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants