Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java cmd] Fix CommandXboxController.leftTrigger() parameter order #5831

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[java cmd] Fix CommandXboxController.leftTrigger() parameter order #5831

merged 2 commits into from
Oct 27, 2023

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Oct 26, 2023 •
edited
Loading

Fixes #5826

@rzblue rzblue requested a review from a team as a code owner October 26, 2023 22:57
@rzblue rzblue changed the title Fix CommandXboxController.leftTrigger() parameter order [java cmd] Fix CommandXboxController.leftTrigger() parameter order Oct 26, 2023
calcmogul
calcmogul requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param tags need to be reordered to match the argument order.

@PeterJohnson PeterJohnson merged commit 3ba501f into wpilibsuite:main Oct 27, 2023
25 of 26 checks passed
@rzblue rzblue deleted the left-trigger-param-order branch December 20, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cmd controllers] Java CommandXboxController.leftTrigger(EventLoop, double) is wrong parameter order
3 participants
@rzblue @calcmogul @PeterJohnson