-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wpiutil] Modify fmt to not throw on write failure #3919
[wpiutil] Modify fmt to not throw on write failure #3919
Conversation
d9cea63
to
6435f31
Compare
6435f31
to
199857d
Compare
Have you tried this end to end with shuffleboard? I published an allwpilib build with this PR. I then built shuffleboard and copied the jar to the tools folder, and it still fails to start on windows via the script. |
No, because I don't have a WPILib dev environment on Windows or macOS. @ThadHouse's stacktrace on macOS was the following, which should be fixed by this PR.
|
But it works on Linux? |
My shuffleboard build may not have pulled in the updated dependencies. I did a clean and then rebuilt shuffleboard and it worked |
No description provided.