Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpiutil] Modify fmt to not throw on write failure #3919

Merged

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul requested review from PeterJohnson and a team as code owners January 14, 2022 03:27
@calcmogul calcmogul force-pushed the fmt-dont-throw-on-write-failure branch 2 times, most recently from d9cea63 to 6435f31 Compare January 14, 2022 03:43
@calcmogul calcmogul force-pushed the fmt-dont-throw-on-write-failure branch from 6435f31 to 199857d Compare January 15, 2022 17:40
@sciencewhiz
Copy link
Contributor

Have you tried this end to end with shuffleboard? I published an allwpilib build with this PR. I then built shuffleboard and copied the jar to the tools folder, and it still fails to start on windows via the script.

@calcmogul
Copy link
Member Author

calcmogul commented Jan 15, 2022

No, because I don't have a WPILib dev environment on Windows or macOS. @ThadHouse's stacktrace on macOS was the following, which should be fixed by this PR.

Thread 47 Crashed:
0   ???                           	    0x7ff89c652940 ???
1   libsystem_kernel.dylib        	    0x7ff80c197112 __pthread_kill + 10
2   libsystem_c.dylib             	    0x7ff80c119d10 abort + 123
3   libc++abi.dylib               	    0x7ff80c18a0b2 abort_message + 241
4   libc++abi.dylib               	    0x7ff80c17b1e5 demangling_terminate_handler() + 242
5   libobjc.A.dylib               	    0x7ff80c0786e6 _objc_terminate() + 104
6   libc++abi.dylib               	    0x7ff80c1894d7 std::__terminate(void (*)()) + 8
7   libc++abi.dylib               	    0x7ff80c18bd55 __cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 27
8   libc++abi.dylib               	    0x7ff80c18bd1c __cxa_throw + 116
9   libwpiutil.dylib              	       0x12ff90e75 fmt::v8::detail::print(__sFILE*, fmt::v8::basic_string_view<char>) + 101
10  libwpiutil.dylib              	       0x12ff90f04 fmt::v8::vprint(__sFILE*, fmt::v8::basic_string_view<char>, fmt::v8::basic_format_args<fmt::v8::basic_format_context<fmt::v8::appender, char> >) + 116
11  libntcore.dylib               	       0x137324db5 nt::LoggerImpl::Log(unsigned int, char const*, unsigned int, char const*) + 453
12  libwpiutil.dylib              	       0x12ff26af2 wpi::Logger::LogV(unsigned int, char const*, unsigned int, fmt::v8::basic_string_view<char>, fmt::v8::basic_format_args<fmt::v8::basic_format_context<fmt::v8::appender, char> >) + 290
13  libwpiutil.dylib              	       0x12ff154f4 wpi::TCPConnector::connect(char const*, int, wpi::Logger&, int) + 1956
14  libntcore.dylib               	       0x1373340c8 0x137311000 + 143560
15  libntcore.dylib               	       0x137331118 nt::DispatcherBase::ClientThreadMain() + 584
16  libntcore.dylib               	       0x13733520e 0x137311000 + 147982
17  libsystem_pthread.dylib       	    0x7ff80c1cd514 _pthread_start + 125
18  libsystem_pthread.dylib       	    0x7ff80c1c902f thread_start + 15

@sciencewhiz
Copy link
Contributor

But it works on Linux?

@sciencewhiz
Copy link
Contributor

My shuffleboard build may not have pulled in the updated dependencies. I did a clean and then rebuilt shuffleboard and it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants