[upstream-utils][mpack] Add upstream util for mpack #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to amalgamate first and then patch the amalgamated version? It feels a bit odd reading the patch because there's unmatched namespace declarations, for example. |
|
You can't really apply the patch to the amalgamated file because it is gitignore'd. You could apply the patch on the allwpilib side, but upstream utils moved away from that concept. Instead I decided to patch the namespace in each c file. This way if it works with the un-amalgamated version of files as well. |
PeterJohnson
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the upstream-util part of #4491. I'll leave the
cmakepart for people more familiar withcmake