[ntcore] Various fixes and cleanups #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PeterJohnson
commented
Nov 2, 2022
•
PeterJohnson
commented
- NetworkTableInstance: set handle to 0 after destroy
- Fix multiple notifications of local values
- Detect mismatch between handles (C/C++ layer done, need to do it at OO layer)
- Fix setting min period from server when no topics are published
- Add ceiling limit to publishers and subscribers to detect accidental leaks
PeterJohnson
force-pushed
the
nt-tweaks
branch
from
7439a29
to
60c81c0
Compare
This helps find resource leaks and prevents them from causing excessive slowdowns/crashes. The limit on each is currently set to 512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.