Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Change WrapperCommand to inherit CommandBase #4561

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[cmd] Change WrapperCommand to inherit CommandBase #4561

merged 1 commit into from
Nov 3, 2022

Conversation

Starlight220
Copy link
Member

Fixes #4553.

Also removed the forwarding of getName, as the wrapper command can be named differently than the wrapped command.

C++ has neither of these issues.

@Starlight220 Starlight220 requested a review from a team as a code owner November 3, 2022 11:42
@PeterJohnson PeterJohnson merged commit 12c2851 into wpilibsuite:main Nov 3, 2022
@Starlight220 Starlight220 deleted the send-wrapper-command branch November 3, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WrapperCommand is not Sendable
2 participants
@Starlight220 @PeterJohnson