[wpimath] Add overloads for Transform2d and Transform3d #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
requested changes
Oct 11, 2023
There was a problem hiding this comment.
The following are missing:
- Transform3d constructor prototype and docs in header file
- Transform2d constructor prototype and docs in header file
- Transform2d constructor definition in source file
- Java version of Transform2d constructor overload
- Java version of Transform3d constructor overload
calcmogul
reviewed
Oct 11, 2023
calcmogul
reviewed
Oct 11, 2023
calcmogul
previously approved these changes
Oct 11, 2023
anitmangal
commented
Oct 11, 2023
|
It seems that PRs created from main branches are causing each other's CI runs to cancel when new changes are pushed. I'm waiting to retrigger this PR's CI until the conflicting CI finishes. (Note that a way to avoid this would be giving PR branches unique names.) |
calcmogul
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overloads for Transform2d() constructor to accept x, y, and heading and for Transform3d() to accept x, y, z and rotation as a shorthand for the normal constructors.
Completes issue #5748.