[wpiunits] Documentation improvements #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agasser
commented
Nov 16, 2023
agasser
commented
Nov 16, 2023
SamCarlberg
requested changes
Nov 17, 2023
|
Are you waiting for anything from me on this PR? |
PeterJohnson
approved these changes
Nov 23, 2023
Starlight220
pushed a commit
to Starlight220/allwpilib
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add missing javadocs to the units library. I used consistent terminology for dimension, unit, and measure. I also added these definitions to frc-docs in a separate PR wpilibsuite/frc-docs#2397. The intention is to make the units library easier to understand using Intellisense.