Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstream_utils] Update to latest Eigen master #5996

Merged

Conversation

calcmogul
Copy link
Member

There hasn't been a release in 2.5 years.

@calcmogul calcmogul requested a review from a team as a code owner December 2, 2023 22:23
There hasn't been a release in 2.5 years.
@sciencewhiz
Copy link
Contributor

This feels like something we'd want more runtime on, since Eigen master probably doesn't have nearly as much as the release from other users. Is there something in master that we need?

@calcmogul
Copy link
Member Author

calcmogul commented Dec 3, 2023

There's performance improvements for some NEON instructions, UB fixes, a lot of internal cleanup with the jump from C++11 to C++14, and more constexpr. They also ran clang-format on the whole repo right before this commit, so I want the Eigen constexpr patches I'm working on to apply after that.

As for testing, Eigen has a CI test suite for aarch64, PPC, and x86-64 that runs for 6-7 hours (the tests eat a lot of RAM when compiling, so they take a while to build). This CI run from a few days ago is the most recent: https://gitlab.com/libeigen/eigen/-/pipelines/1090190828. The main thing a release goes through that master doesn't is the devs poke at a release candidate first.

Eigen hasn't put out a new release, even for bugfixes, in 2.5 years because their maintainers have a combined 15 minutes per week to work on Eigen (i.e., they don't have the time to maintain the project properly). I've considered migrating us to a better maintained linear algebra library that targets a newer C++ standard, but they all have Fortran library dependencies that are difficult to build and manage. Eigen is the only one with "batteries included" and optional BLAS/LAPACK support.

@PeterJohnson PeterJohnson merged commit e8f8c0c into wpilibsuite:main Dec 4, 2023
27 checks passed
@calcmogul calcmogul deleted the upstream-utils-update-eigen branch December 4, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants