Add support for signing binaries #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the idea plug-in has nothing to do with signing binaries. You'll need to look at what the line was when the issue was opened, not current main. |
|
That makes sense, https://github.com/wpilibsuite/allwpilib/blob/561d53885edb68149f94f76867ca409808b4b971/build.gradle#L104 seems more useful |
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
spacey-sooty
force-pushed
the
sign-binaries
branch
from
c71f624
to
c72ac88
Compare
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 2, 2024
Requires wpilibsuite/native-utils#219 Signed-off-by: Jade Turner <[email protected]>
rzblue
reviewed
Oct 2, 2024
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
|
I'm not the biggest fan of the options name suggestions welcome |
Signed-off-by: Jade Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #65