Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nodir:true in gulp src when creating the .zip #604

Closed
wants to merge 1 commit into from
Closed

Use nodir:true in gulp src when creating the .zip #604

wants to merge 1 commit into from

Conversation

ataylorme
Copy link
Contributor

Description

Addresses issue #594. gulp src passes directories by default. However, on Windows and Linux the permissions are different so if the prod bundle is created on a Windows machine and deployed to a Linux server there are issues. Setting nodir: true in gulp src is a workaround suggested here.

List of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • This pull request relates to a ticket.
  • This code is tested.
  • This change has been added to CHANGELOG.md
  • I want my code added to WP Rig.

@ataylorme
Use nodir:true in gulp src when creating the .zip
75053c7 
See wprig#594. gulp `src` passes directories by default. However, on Windows and Linux the permissions are different so if the prod bundle is created on a Windows machine and deployed to a Linux server there are issues. Setting `nodir: true` in gulp `src` is a workaround suggested [here](sindresorhus/gulp-zip#64 (comment)).
@ataylorme ataylorme added bug Something isn't working gulp Gulp related issues labels Sep 16, 2019
@ataylorme ataylorme added this to the v2.0.2 milestone Sep 16, 2019
@ataylorme ataylorme self-assigned this Sep 16, 2019
@ataylorme ataylorme mentioned this pull request Sep 16, 2019
Open
@mor10
Copy link
Contributor

mor10 commented Sep 19, 2019

I was sortof able to test this. Works on Windows, and works on my weird Linux install on an RPI, but would be good to get it tested by someone who has a more legit Linux workflow.

@robruiz robruiz mentioned this pull request Dec 30, 2020
Merged
3 tasks
@robruiz robruiz closed this Dec 30, 2020
@robruiz robruiz deleted the branch wprig:develop December 30, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mor10 mor10 mor10 approved these changes

Assignees

@ataylorme ataylorme

Labels
bug Something isn't working gulp Gulp related issues needs-testing
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ataylorme @mor10 @robruiz