Add Num.[max/min]SafeInteger
#874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChayimFriedman2
force-pushed
the
min-max-safe-integers
branch
from
1caa566
to
a66357d
Compare
ChayimFriedman2
force-pushed
the
min-max-safe-integers
branch
from
a66357d
to
58f2595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These represent the maximum and the minimum integers that all integers below/above them can be represented accurately (without precision loss), accordingly.
These constants are defined in JS (
Number.MAX_SAFE_INTEGER,Number.MIN_SAFE_INTEGER).For example, the
fmtmodule by PureFox48 neededmaxSafeInteger, and hand-crafted it (https://github.com/NinjasCL-labs/wren-rosetta/blob/832a71ebfa1b817aa06bb9541408f8b6d9a652ef/src/fmt.wren#L18-L19). I thought it would be nice to have that built in.