Optimize some Sequence methods on Range and List
#901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods that got optimized: - `toList` in both `Range` and `List`. They both preallocate enough space instead of keeping adding elements. On `List` we also use `memcpy()` to effectively copy the list. - `count` and `contains(_)` on `Range`. They both calculates the value now instead of iterating over the range to determine it. - `take(_)` and `skip(_)` on `Range`. They both return a new precalculated range instead of a dedicated sequence (`TakeSequence` and `SkipSequence`, respectively, in wren_core.wren). This is not a major gain, but it allows the previous optimized method to be used on the result instead of their slower `Sequence` counterparts. All methods were implemented in C rather than Wren.
ChayimFriedman2
force-pushed
the
optimize-sequence-methods-for-subclasses
branch
from
ae06287
to
4cc6e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods that got optimized:
toListin bothRangeandList. They both preallocate enough space instead of keeping adding elements. OnListwe also usememcpy()to effectively copy the list.countandcontains(_)onRange. They both calculates the value now instead of iterating over the range to determine it.take(_)andskip(_)onRange. They both return a new precalculated range instead of a dedicated sequence (TakeSequenceandSkipSequence, respectively, in wren_core.wren). This is not a major gain, but it allows the previous optimized method to be used on the result instead of their slowerSequencecounterparts.All methods were implemented in C rather than Wren.