Optimize some Sequence
methods on Range
and List
#901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods that got optimized:
toList
in bothRange
andList
. They both preallocate enough space instead of keeping adding elements. OnList
we also usememcpy()
to effectively copy the list.count
andcontains(_)
onRange
. They both calculates the value now instead of iterating over the range to determine it.take(_)
andskip(_)
onRange
. They both return a new precalculated range instead of a dedicated sequence (TakeSequence
andSkipSequence
, respectively, in wren_core.wren). This is not a major gain, but it allows the previous optimized method to be used on the result instead of their slowerSequence
counterparts.All methods were implemented in C rather than Wren.