fix: [#268] do not validate URL when skip flag is used #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I stumbled upon #268 and saw you added the
-s, --skip-validation-check
flag. I checked the fix, but if I interpret the code correctly, it still does validate the URL, but now it just ignores the result. This does not fix the issue with one-time URL's described in #268 (comment). The name of the flag also suggests it completely skips the check instead of ignoring the result, so that's what I changed it into.Types of changes
Checklist: