Improve serializeJSON() #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tries to improve serializeJSON() to get closer to rfc4627. It includes a more proper quoting of strings and output of integers instead of floats where appropriate.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to improve serializeJSON() to get closer to rfc4627.
It includes a more proper quoting of strings and output of integers
instead of floats where appropriate.
Purpose
At the moment the serializeString() method replaces only a subset of control characters that are allowed in JSON, hence stringify() may not serialize to valid JSON.
Goals
Add a better string quoting, closer to rfc4627.
Approach
Add a quote() method that walks through the chars of a string and replaces all escapable chars to their quoted "\uXXXX" counterpart.