Repaired 404 exemption inconsistency #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed an inconsistent behavior for when a 404 is being exempted/not exempted from a CSRF check.
Initially in our repo, we had no
@csrf.exempt
calls and so a test like the following would receive a CSRF error (not a 404):However, after we add an
@csrf.exempt
to an existing endpoint, we noticed that we would instead yield a 404 at the endpoint in our tests:This inconsistent behavior is undesirable as some people might be writing integration tests to verify CSRF works.
To remedy that, we have decided to exempt all 404 requests to CSRF checks. In this PR:
self._exempt_views or self._exempt_blueprints
conditional