Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go modules #406

Closed
retgits opened this issue Apr 17, 2019 · 7 comments
Closed

Go modules #406

retgits opened this issue Apr 17, 2019 · 7 comments
Labels
💪 improvement "Where we're going, we don't need roads."

Comments

@retgits
Copy link
Contributor

retgits commented Apr 17, 2019

@senorprogrammer, is wtf looking at moving to Go modules? If so, I'd love to help out make the move 😄

@senorprogrammer senorprogrammer added the 💪 improvement "Where we're going, we don't need roads." label Apr 17, 2019
@senorprogrammer
Copy link
Collaborator

Yes, absolutely. Before that I want to ensure that creating a module is much easier than it is now, and has less (ideally no) dependencies on the underlying platform used for display (tcell, etc.). This branch is currently in progress to move in that direction: #402

Do you have thoughts about how modules would look for wtf?

@retgits
Copy link
Contributor Author

retgits commented Apr 21, 2019

I think that Go modules and modules for WTF are slightly different, but could be closely related.

For Go modules specifically, it would allow WTF to remove the vendor directory and replace the Gopkg.* files with go.mod and go.sum. Especially with Go 1.12, the support for modules is really where it should be in terms of dependency management. It could/should also speed up the build process quite a bit.

@senorprogrammer
Copy link
Collaborator

Right, I was conflating the two. Having Go modules is definitely the direction it should go. I would love to see the vendor directory go away.

@retgits
Copy link
Contributor Author

retgits commented Apr 22, 2019

Awesome! Would you mind if I take a stab at it? If so, is there a particular branch you want me to work off?

@senorprogrammer
Copy link
Collaborator

Go for it. Create a new branch off master and you're good.

@retgits retgits mentioned this issue Apr 26, 2019
@retgits
Copy link
Contributor Author

retgits commented Apr 26, 2019

Just created a PR for it 😄(#417) I know the PR description is a bit on the long side, but I wanted to thoroughly document the changes I made to make your review easier.

@senorprogrammer
Copy link
Collaborator

Closed from #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 improvement "Where we're going, we don't need roads."
Development

No branches or pull requests

2 participants