WTF-400 Extracting config out of modules #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senorprogrammer
force-pushed
the
WTF-400-widget-configs
branch
from
c8fe822
to
ccd8bd3
Compare
senorprogrammer
changed the title
senorprogrammer
force-pushed
the
WTF-400-widget-configs
branch
from
87f80ea
to
008d366
Compare
added 21 commits
April 15, 2019 10:05
senorprogrammer
force-pushed
the
WTF-400-widget-configs
branch
from
7f1b552
to
9b41e6e
Compare
added 5 commits
April 15, 2019 10:46
senorprogrammer
force-pushed
the
WTF-400-widget-configs
branch
from
56bd0bd
to
daa422a
Compare
added 9 commits
April 16, 2019 17:09
Closed
added 10 commits
April 17, 2019 17:16
senorprogrammer
force-pushed
the
WTF-400-widget-configs
branch
from
57f29db
to
6227b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fundamentally reworks the settings system by removing all knowledge of the YAML config and
github.com/olebedev/configfrom the widgets.Each widget now has its own
Settingstype in its package that is populated by whichever means (in the case of the app itself, aNewSettingsFromYAMLfunction that takes the output ofconfig) and is now passed to the widget for configuration.Beyond separating concerns, this should
a) make it a bit easier to test modules
b) make it possible to change settings in a widget dynamically from within the app
c) start to lay the groundwork for multi-instance widgets