Rollbar module broken?

[International]

What's broken?

Hello, been trying to configure the rollbar module. Nothing gets displayed, and after adding some logs, it looks like the refreshInterval parameter is not being configured.

Shouldn't the last call from widget.Refresh not be to Refresh, but perhaps widget.Render instead?

Thanks

[senorprogrammer]

Can you paste a copy of your config for Rollbar (redacting any API credentials etc. if necessary). I don't use Rollbar but might be able to help. It's also entirely possible that module is broken.

[International]

I just took the default one, and changed the accessToken, projectOwner and projectOwner. If you would like to debug it, you could change this in client.CurrentActiveItems:

func CurrentActiveItems(accessToken, assignedToName string, activeOnly bool) (*ActiveItems, error) {
	items := &ActiveItems{}

	rollbarAPIURL.Host = "api.rollbar.com"
	rollbarAPIURL.Path = "/api/1/items"
	//resp, err := rollbarItemRequest(accessToken, assignedToName, activeOnly)
	//if err != nil {
	//	return items, err
	//}
	//
	//parseJSON(&items, resp.Body)
	items.Results.Items = []Item{
		{Environment: "prod", Title: "show me", },
	}

	return items, nil
}

so that you wouldn't need to do an actual network call. It's how I was debugging also.

[Seanstoppable]

You are correct that we should be calling Render rather than having Refresh call itself. I've opened up a PR, but I don't have rollbar myself to test @International

[International]

i will verify the pr in a few hours, and update it with a comment

…

On Sun, 21 Jul 2019 at 18:14, Sean Smith ***@***.***> wrote: You are correct that we should be calling Render rather than having Refresh call itself. I've opened up a PR, but I don't have rollbar myself to test @International <https://github.com/International> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#507?email_source=notifications&email_token=AAHZXRVSP4KKL3TF4XGZRZ3QAR4NVA5CNFSM4IE6W7R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2OFRTQ#issuecomment-513562830>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHZXRW7DWWAJRFY5RRSJH3QAR4NVANCNFSM4IE6W7RQ> .

[senorprogrammer]

Waiting for verification before closing this issue

[International]

I can confirm it works. Thanks!